parsingdata / metal

A Java library for parsing binary data formats, using declarative descriptions.
Apache License 2.0
18 stars 9 forks source link

Refactor 6 lines occurring 7 times in 7 files: Last.java, First.java, Count.java, UnaryValueExpression.java, FoldCat.java, UnaryLogicalExpression.java, Bytes.java #246

Open rdvdijk opened 6 years ago

rdvdijk commented 6 years ago

I've selected for refactoring 6 lines of code which are duplicated in 7 file(s) (1, 2, 3, 4, 5, 6, 7). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: :sparkles: :100:

rdvdijk commented 6 years ago

Let's see if we can rename UnaryValueExpression to OneToOneValuExpression and introduce a new OneToManyValueExpression to deduplicate code.

Let's see if we can rename UnaryValueExpression to OneToManyValuExpression and introduce a new OneToOneValueExpression to deduplicate code.