search

parsingdata / metal

A Java library for parsing binary data formats, using declarative descriptions.
Apache License 2.0
18 stars 9 forks source link

#413: Add test to DefUntil to test the list semantics. #414

Closed mvanaken closed 6 months ago

mvanaken commented 7 months ago

This test shows how multiple values for initialSize, stepSize and maxSize are used together and which offsets in which order are used to parse the terminator.

This was missing in our test base. We had 100% test coverage, because also with single values, we process them as lists. Clear example that line coverage is not the same as test coverage. ;)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (16cc984) to head (d97154e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #414 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 1150 1150 =========================================== Files 98 98 Lines 1537 1537 Branches 159 159 =========================================== Hits 1537 1537 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mvanaken commented 6 months ago

Because I simply added a test, decided to merge it without any reviews.