search

parsivori / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

remove preg_replace /e modifier #533

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

The preg_replace() /e modifier is slated for deprecation in PHP 5.5, so you 
want to consider to remove use of it preemptively.Read more here: 
https://wiki.php.net/rfc/remove_preg_replace_eval_modifier

I've scanned the source and found two instances. The one in GenerateGroups.php 
I've fixed, see attached patch. Patch happens to include some pending doc fixes 
aswell.

The other is in lib/Auth/Yadis/ParseHTML.php; since this is an external library 
you may not want to patch it locally but instead have that fixed unstream. But 
if you want to patch it locally it should be feasible to solve it in a similar 
way.

Original issue reported on code.google.com by thijs@kinkhorst.com on 15 Jan 2013 at 12:30

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks! Committed in r3222 (documentation) and r3223 (core:GenerateGroups).

Original comment by olavmrk@gmail.com on 17 Jan 2013 at 8:00