search

parsivori / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

fopen failure in Statistics Aggregator #598

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. enable the statistics module
2. remove permissions on the file "simplesamlphp.stat"
3. try to run the cron to process statistics

What is the expected output? What do you see instead?
A beautiful error is expected, because it is not supposed to work.
An infinite loop of errors/warnings showed up (on my config) due to the while 
loop below the fopen() function (located in 
modules/statistics/lib/Aggregator.php:79)
fopen fails but the return value is not tested, so the script continues.
I've joined a patch for this.

What version of the product are you using? On what operating system?
SSP 1.11, Ubuntu 13.04

I agree it's not critical, but it feels weird when you have 300MB of logs just 
because you ran your cron ;-)

Original issue reported on code.google.com by thib.ack...@gmail.com on 25 Nov 2013 at 5:12

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi,

I've just submitted a fix for this bug, and it's available in r3317.

Thanks a lot for reporting, and happy new year!

Original comment by jaim...@gmail.com on 6 Jan 2014 at 7:07