search

parsotat / BatAnalysis

A python HEASOFT wrapper for processing Swift-BAT data.
MIT License
28 stars 11 forks source link

add type check before comparison of binning_timedelta to a 1M timedel… #21

Closed Parrazyte closed 2 months ago

Parrazyte commented 3 months ago

…ta64 in group_outventory

parsotat commented 2 months ago

@Parrazyte I took a look at your PR and I was wondering if you can explain the last two commits to prevent parallelization with nprocs=1. The joblib Parallel function allows for n_jobs to be 1 which prevents any parallelization and makes the BatAnalysis functions easier to read. Since these last two commits seem to be redundant, I would suggest removing them and then I will accept the PR for Fixing #20 and #22.

parsotat commented 2 months ago

Closed via PR #26