part4-1st-team / coworkers

์Šคํ”„๋ฆฐํŠธ 7๊ธฐ part4 ํ”„๋กœ์ ํŠธ
1 stars 4 forks source link

refactor/#152 refactor skeleton #219

Closed kanghyosung1 closed 1 month ago

kanghyosung1 commented 1 month ago

๐Ÿ˜Ž ๋‹ด๋‹น์ž

์–ด๊นจํ”ผ์ž ๊ฐ•ํšจ์„ฑ

์•ž์— ํ˜•์šฉ์‚ฌ ๋ถ™์—ฌ์ฃผ์„ธ์š” ~~ ex) ๊ท€์—ฌ์šด OOO

ใ…ค

๐Ÿงฉ ์ด์Šˆ ๋ฒˆํ˜ธ

์ด์Šˆ ๋ฒˆํ˜ธ ์ ์–ด์ฃผ์„ธ์š”

  • 152

    ใ…ค

โœจ ์ž‘์—… ๋‚ด์šฉ

์ž‘์—…ํ•œ ๋‚ด์šฉ์„ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”

  • ์ž์œ  ๊ฒŒ์‹œํŒ ์Šค์ผˆ๋ ˆํ†ค ์ ์šฉ
  • ๋žœ๋”ฉํŽ˜์ด์ง€ ์ง€๊ธˆ์‹œ์ž‘ํ•˜๊ธฐ ์ด๋™๊ฒฝ๋กœ ์ถ”๊ฐ€
  • ์กฐํšŒ์ˆ˜ ์ด์Šˆ ๋ฐœ์ƒํ•˜์—ฌ ์ˆ˜์ • ใ…ค

๐Ÿ’ก ์ด๋ฒˆ pr์„ ์˜ฌ๋ฆฌ๊ธฐ ์ „์— ๋ฐ›์€ ํ”ผ๋“œ๋ฐฑ์ด ์žˆ๋‚˜์š”? (์žˆ์œผ๋ฉด ์ฒดํฌ๋ฆฌ์ŠคํŠธ ์ž‘์„ฑ)

ใ…ค

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท ๋˜๋Š” GIF

ui ์ปดํฌ๋„ŒํŠธ ๊ฐœ๋ฐœ, ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ์„ ํ–ˆ๋‹ค๋ฉด ์Šคํฌ๋ฆฐ์ƒท๋„ ์˜ฌ๋ ค์ฃผ์„ธ์š”

ใ…ค

โœ๐Ÿป ์ฐธ๊ณ ์‚ฌํ•ญ

ํŒ€์›๋“ค์ด ์ฐธ๊ณ ํ•ด์•ผํ•  ๋ถ€๋ถ„์ด ์žˆ๋‹ค๋ฉด ์ ์–ด์ฃผ์„ธ์š”

ใ…ค


์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋‚จ๊ธธ๋•Œ ์ฐธ๊ณ ์šฉ (pr ์ž‘์„ฑํ•  ๋•Œ ์ง€์šฐ์ง€ ๋ง๊ธฐ)

P1: ๊ผญ ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š” (Request changes) - ๋ฆฌ๋ทฐ์–ด๋Š” PR์˜ ๋‚ด์šฉ์ด ์„œ๋น„์Šค์— ์ค‘๋Œ€ํ•œ ์˜ค๋ฅ˜๋ฅผ ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ๋Š” ๊ฐ€๋Šฅ์„ฑ์„ ์ž ์žฌํ•˜๊ณ  ์žˆ๋Š” ๋“ฑ ์ค‘๋Œ€ํ•œ ์ฝ”๋“œ ์ˆ˜์ •์ด ๋ฐ˜๋“œ์‹œ ํ•„์š”ํ•˜๋‹ค๊ณ  ํŒ๋‹จ๋˜๋Š” ๊ฒฝ์šฐ, P1 ํƒœ๊ทธ๋ฅผ ํ†ตํ•ด ๋ฆฌ๋ทฐ ์š”์ฒญ์ž์—๊ฒŒ ์ˆ˜์ •์„ ์š”์ฒญํ•ฉ๋‹ˆ๋‹ค. ๋ฆฌ๋ทฐ ์š”์ฒญ์ž๋Š” p1 ํƒœ๊ทธ์— ๋Œ€ํ•ด ๋ฆฌ๋ทฐ์–ด์˜ ์š”์ฒญ์„ ๋ฐ˜์˜ํ•˜๊ฑฐ๋‚˜, ๋ฐ˜์˜ํ•  ์ˆ˜ ์—†๋Š” ํ•ฉ๋ฆฌ์ ์ธ ์˜๊ฒฌ์„ ํ†ตํ•ด ๋ฆฌ๋ทฐ์–ด๋ฅผ ์„ค๋“ํ•  ์ˆ˜ ์žˆ์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

P2: ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š” (Request changes) - P2์— ๋Œ€ํ•ด ์ˆ˜์šฉํ•˜๊ฑฐ๋‚˜ ๋งŒ์•ฝ ์ˆ˜์šฉํ•  ์ˆ˜ ์—†๋Š” ์ƒํ™ฉ์ด๋ผ๋ฉด ์ ํ•ฉํ•œ ์˜๊ฒฌ์„ ๋“ค์–ด ํ† ๋ก ํ•  ๊ฒƒ์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค.

P3: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Comment) - P3์— ๋Œ€ํ•ด ์ˆ˜์šฉํ•˜๊ฑฐ๋‚˜ ๋งŒ์•ฝ ์ˆ˜์šฉํ•  ์ˆ˜ ์—†๋Š” ์ƒํ™ฉ์ด๋ผ๋ฉด ๋ฐ˜์˜ํ•  ์ˆ˜ ์—†๋Š” ์ด์œ ๋ฅผ ๋“ค์–ด ์„ค๋ช…ํ•˜๊ฑฐ๋‚˜ ๋‹ค์Œ์— ๋ฐ˜์˜ํ•  ๊ณ„ํš์„ ๋ช…์‹œ์ ์œผ๋กœ ํ‘œํ˜„ํ•ฉ๋‹ˆ๋‹ค.

P4: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค (Approve) - ํ•ด๋‹น ์˜๊ฒฌ์„ ๋ฐ˜์˜ํ•˜๋Š” ๊ฒŒ ์ข‹์„์ง€ ๊ณ ๋ฏผํ•ด ๋ณด๋Š” ์ •๋„๋ฉด ์ถฉ๋ถ„ํ•ฉ๋‹ˆ๋‹ค

P5: ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Approve) - ์•„๋ฌด๋Ÿฐ ์˜๊ฒฌ์„ ๋‹ฌ์ง€ ์•Š๊ณ  ๋ฌด์‹œํ•ด๋„ ๊ดœ์ฐฎ์Šต๋‹ˆ๋‹ค

PQ: ์งˆ๋ฌธ์ž…๋‹ˆ๋‹ค (Question) - ์งˆ๋ฌธ์—๋Š” ๊ผญ ๋‹ต์„ ํ•ด์ฃผ์„ธ์š”

netlify[bot] commented 1 month ago

Deploy Preview for coworkers-1 ready!

Name Link
Latest commit 694a52cdaec50e38cedde21be74361ef59fb8b2b
Latest deploy log https://app.netlify.com/sites/coworkers-1/deploys/670615b8bceb7e0008cd2f49
Deploy Preview https://deploy-preview-219--coworkers-1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.