nus-pe-bot
commented
1 year ago Team's Response
Good catch, however, it is very rare that a user would dig into the data files and modify it to become an invalid value.
Only advanced users would modify the data files, and advanced users should know what they are doing.
Items for the Tester to Verify
:question: Issue type
Team chose [type.DocumentationBug]
Originally [type.FeatureFlaw]
- [x] I disagree
Reason for disagreement: I am fine with severity.Low, but this bug report is not a DocumentationBug, because the behaviour of the app is not as expected. It can be considered a FunctionalityBug because the behaviour of the app does not match the UG where "Rapportbook will discard all data and start with an empty data file at the next run", or it can be considered a FeatureFlaw because the checks for invalid fields in reminders.json could be better.
it is very rare that a user would dig into the data files and modify it to become an invalid value.
Accepted as justification for severity.Low
advanced users should know what they are doing.
Normally, yes, but even the best of us can make mistakes. The point is that the feature is not working as advertised (that invalid fields will cause data to be discarded).
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Edit 'reminders.json' to have an invalid date as shown below.
From the UG, "If your changes to the data file makes its format invalid, Rapportbook will discard all data and start with an empty data file at the next run." But it is not at all clear that edits to 'reminders.json' will only invalidate the data for reminders and not for all the data including client data.
Why should the user be notified of any parsing errors in reminders.json, or why should any parsing errors from reminders.json invalidate all data? Because the user will continue to use the app as expected. If there are many reminders, and if just one of them has an invalid date but is a really important reminder, the user will not realise that this important reminder is missing.