search

parth-io / pe

0 stars 0 forks source link

Help window is not displayed at all #2

Open parth-io opened 1 year ago

parth-io commented 1 year ago

To reproduce, simply type help or press the 'Help' button. In either case, on my computer, the Help window does not show up at all. Please view the screenshot and the screen recording for details. Details of my set-up: Linux parth 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

image.png
video:https://raw.githubusercontent.com/parth-io/pe/main/files/13e2edeb-8678-49e9-9dab-1acdc20dd68f.mp4

image.png

nus-se-bot commented 1 year ago

Team's Response

This is our testing on Ubuntu. The help window displays as normal.

image.png

It is simply not feasible for us to test all the different distros of Linux, and we did already test our application in Windows, macOS and Linux (on Ubuntu, the most popular distro), thus fulfilling the criteria/constraint of the tp on operating systems.

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: Would like the teaching team to set this as NotInScope (reasoning given at the end)

I did some digging to understand why this happens only on KDE, and I found the reason:

In line 12 of HelpWindow.fxml, remove resizable="false". The line should then look like this:

fx:root title="Help" type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/11" xmlns:fx="http://javafx.com/fxml/1"

image.png

Upon making this fix, the Help Window appears. This fix works for Windows as well (have not tested on MacOS, Gnome or other Linux Desktop Environments).

As this is still a valid bug that has a fix, I disagree with the dev team's reasoning that it cannot be reproduced.

However, I understand that it is impossible to expect us students to test on all of Linux's DEs (this is perhaps a Qt or KDE-specific window manager bug), so I would like to request the teaching team to classify this as a FeatureFlaw that is NotInScope, because comprehensive Linux support will only be guaranteed in the later versions.