Empty arguments for parameters should be disallowed

[parth-io]

Steps to reproduce:

1. Type add n=Laufey p=98980184 e=laufey@u.nus.edu a=123,Clementi r=

The parameter r= has no arguments, yet it is accepted. It is prudent to warn the user or throw an error message that this is meaningless input, and get the user to either remove the r= or add the remark.

[nus-se-bot]

Team's Response

Remark can be an empty string. Furthermore, the current behavior is the expected behavior.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: Request to teaching team: to change to FeatureFlaw and NotInScope

Remark can be an empty string.

But this is an implementation detail, where String remark = ""; is valid. But for a user to type an empty string is meaningless, because by specifying r=, the user does intend to type something. If the user simply forgot to type a remark, an error message saying that the remark field is empty can help the user add the missing remark. Silently accepting it will not alert the user that he forgot to add the remark.

Furthermore, the current behavior is the expected behavior.

On consideration, yes, the current behaviour is expected though erronenous. Since I was in a rush during the PE and didn't consider this thoroughly, can I request the teaching team to change the type to FeatureFlaw, as this lack of input checking makes the remark feature sub-optimal, and to mark it as NotInScope as "the user cannot attempt to use the missing feature"?

---