search

parth-io / pe

0 stars 0 forks source link

Date parsing silently allows invalid dates to be parsed #8

Open parth-io opened 1 year ago

parth-io commented 1 year ago

30 Feb is an invalid date

  1. Type reminder 5 d=Zoom meeting dt=22-30-20 11:00

Expected: An error message to be thrown, as the user should at least be warned that he's making a mistake and that this date is not a valid one

image.png

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

reminder date 30/02/YYYY

Steps to Reproduce

run reminder 1 d=Reminder dt=03-02-30 23:00

Expected

Some message saying date is invalid or that the year is in the past.

Actual

Rounds date to 2003-02-28 and no message that date is in the past (although the year being in the past is a feature flaw).

[original: nus-cs2103-AY2223S1/pe-interim#5400] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We can reproduce the issue of date rounding for February, but accepting dates that are in the past is intentional as we explicitly show expired reminders in red.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]