search

parthenon-hpc-lab / athenapk

AthenaPK: a performance portable version of Athena++ built on Parthenon and Kokkos
BSD 3-Clause "New" or "Revised" License
53 stars 13 forks source link

Add option to use `mbar` when using physical temperatures #22

Open pgrete opened 1 year ago

pgrete commented 1 year ago

Migrated from GitLab: https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/8:

In the future, mbar might be the more generalizable parameter for defining the temperature. We could add it as an alternative to defining He_mass_fraction. However, since He_mass_fraction is used elsewhere during the cluster setup, we can leave it as it for now.

BenWibking commented 1 year ago

This would also be useful for my problem generator.