Closed Yurlungur closed 3 months ago
Now documented. This is completely ready for review. No tests, as I don't want us to add Visit or Paraview to our CI, but tested by hand with Visit and Paraview.
Thanks @pgrete I'll make these changes and submit a tirival PR to fix
PR Summary
This PR is designed to support codes like
Phoebus
,Artemis
, andAssail
downstream that uses coordinates that are not the uniform cartesian coordinate system. It lets you tag a mesh variable as a coordinates array. To do say, make your variable a node-centered 3-vector and add theMetadata::CoordinatesVec
MetadataFlag
to it. Then fill this variable with thex
,y
, andz
coordinates of your nodes as appropriate.If you do this, the variable will automatically be output in dumps and restarts and the xdmf file will will record this field as your coordinates per meshblock. Tested in
parthenon-mhd
.This is also ready for downstream testing and review in downstream codes. Depends on #1019 . I haven't fully cleaned up formatting/linting/docs yet.
PR Checklist