Closed Yurlungur closed 5 months ago
Thanks for the review @pgrete I think I've addressed your comments now.
@lroberts36 thanks for the review. I think I've addressed all your comments.
With the latest changes the distinction between if (grid.type == GridType::two_level_composite) {
and using pmy_mesh_->gmg_block_lists[src->grid.logical_level][i]
is gone.
Is that not required any more?
@pgrete: Yeah, that is no longer required since the src
MeshData
already should point to internal/multigrid blocks.
PR Summary
This PR adds the ability to request a new
MeshData
orMeshBlockData
object by requesting a subset of unique IDs of variables from the parent object, rather than by using only variable names. This should make UID-based operations more usable and thus unlock a bit of performance by minimizing string comparisons. Needed in riot and I suspect also KHARMA.PR Checklist