Closed brryan closed 5 months ago
@brryan is this ready for review? It's still marked WIP
@brryan is this ready for review? It's still marked WIP
@Yurlungur Yes it works but I just wanted to see what people think about including OutputParameters*
in the function signature for UserWorkBeforeRestartOutput
(and somehow extending UserWorkBeforeOutput
in the same way?) so we could get things like output filename downstream.
OK I updated this to reintroduce explicitness around nullptr
with std::function
and I removed the per-MeshBlock version of UserWorkBeforeRestartOutput
. What I did not do is:
UserWorkBeforeOutput
Change the signature of UserWorkBeforeOutput
to include OutputParameters
.
That would pick up two breaking changes so maybe we want to get some consensus on a separate PR that refactors some of these hooks sometime in the future? If so I think this is ready to go, @pgrete if you are OK to approve (and others don't want to pause before merge) I will then go ahead and merge this in.
PR Summary
We have a downstream need to call a third party library's restart capability when writing our own restarts. This PR adds hooks for
Mesh
andMeshBlock
analogs ofUserWorkBeforeOutput
that are only triggered during restart outputs.PR Checklist