parthenon-hpc-lab / parthenon

Parthenon AMR infrastructure
https://parthenon-hpc-lab.github.io/parthenon/
Other
105 stars 33 forks source link

add fail on edge case in Mesh Data #1064

Closed Yurlungur closed 2 months ago

Yurlungur commented 2 months ago

PR Summary

As discussed in MR #1060 and in the parthenon call, there are edge cases when you add mesh data on a partition. This just prevents you from doing that.

PR Checklist

Yurlungur commented 2 months ago

Does the comment above still properly reflect this check (basically telling future us' if there's still a need to fix sth)?

It's still relevant if we ever want to make Add work on subsets of the mes. So I'd rather keep it.