parthenon-hpc-lab / parthenon

Parthenon AMR infrastructure
https://parthenon-hpc-lab.github.io/parthenon/
Other
112 stars 33 forks source link

Fix bug in static refinement #1071

Closed lroberts36 closed 4 months ago

lroberts36 commented 4 months ago

PR Summary

The re-definition of Mesh::root_level introduced in #1053 did not get correctly propagated through the static refinement related code (which operates on logical locations relative to the legacy tree). This PR fixes that issue, which had cropped up in Artemis.

PR Checklist

lroberts36 commented 4 months ago

Agreed, we need to add a couple tests that use multi-tree forests. We have at least one that uses SMR, but the bug does not manifest if the base grid only requires one tree.

lroberts36 commented 4 months ago

The updated gold files are in #1073, right?

Yeah, I added the new gold files required here (and in #1047) to v23 so that I didn't have to upgold a bunch of times.