parthenon-hpc-lab / parthenon

Parthenon AMR infrastructure
https://parthenon-hpc-lab.github.io/parthenon/
Other
112 stars 33 forks source link

A few Kokkos quality of life improvements #1078

Closed Yurlungur closed 4 months ago

Yurlungur commented 4 months ago

PR Summary

In #1075 @brryan recently reported that 1D par_reduce doesn't seem to work. I think this is because it's not supported for the all loop patterns, including simd for loops, which are default on CPU builds. I resolve this by just falling back to Kokkos for all loop patterns in 1D.

I also add overloads in 1D for IndexRange instead of a start and end pair of indices. If this is desirable I can add overloads and fallbacks for other patterns and dimensions in a later pull request.

PR Checklist