parthenon-hpc-lab / parthenon

Parthenon AMR infrastructure
https://parthenon-hpc-lab.github.io/parthenon/
Other
105 stars 33 forks source link

Address XDMF/Visit Issues #1079

Closed pdmullen closed 1 month ago

pdmullen commented 2 months ago

Visualizing HDF5 + XDMF files generated through develop with VisIt produces strange artifacts wherein 2D datasets often show a protruding X3 feature (which looks like a skyscraper). This MR attempts to fix such artifacting by adjusting the data dumped in HyperSlab DataItems.

Parthenon particles cannot be visualized in VisIt currently, and their corresponding mesh is not even dumped in our current XDMF files. For the life of me, I cannot get VisIt to interpret VXVYVZ type geometries for Polyvertex meshes. I find that in order to get Visit to read our Polyvertex mesh, I must recast the geometry as an array of type {{x1, y1, z2}, {x2, y2, z2}...}. Even after that change, I cannot get Visit to see the Polyvertex mesh unless it is its own XDMF file. Visit can still plot particles on top of field variables if both XDMF files are read and a correlation is instantiated (VisIt prompts users automatically for this). This MR enables users to optionally dump out swarm XDMF files, which, if enabled, also dumps restructured particle geometry in the corresponding HDF5 file. Restart files should remain unchanged.

This is gross. Feel free to shoot down this MR.

PR Summary

PR Checklist

pdmullen commented 2 months ago

Am I missing something? I can't find this change in the diff.

@Yurlungur https://github.com/parthenon-hpc-lab/parthenon/pull/1079/files#diff-31b92df33d462322a957c4750de1874912d6947009746063e9684dae98314675R515