parthenon-hpc-lab / parthenon

Parthenon AMR infrastructure
https://parthenon-hpc-lab.github.io/parthenon/
Other
105 stars 33 forks source link

add macOS CI #1080

Closed BenWibking closed 1 month ago

BenWibking commented 2 months ago

Adds macOS CI on GitHub actions.

PR Summary

This helps ensure Parthenon runs smoothly on macOS.

This PR may not complete successfully when it's first run (most likely due to missing dependencies), since GitHub provides no way to test actions before running them in production. If this happens, I will create a new PR to fix any issues that arise.

PR Checklist

pdmullen commented 1 month ago

LGTM! Looks like it is testing again MacOS Sonoma; if we want to keep testing the latest OS, then we may periodically have to bump.

BenWibking commented 1 month ago

LGTM! Looks like it is testing again MacOS Sonoma; if we want to keep testing the latest OS, then we may periodically have to bump.

Good catch, thanks! I've changed it to use the macos-latest image, which should as of today, run on macOS Sonoma on Apple Silicon (https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/).

BenWibking commented 1 month ago

It looks like GitHub doesn't run new CI actions in PRs, so there's a good chance this will fail in some way when it's run (most likely due to missing dependencies in the macOS image). I will create a PR to fix things if this happens.

Yurlungur commented 1 month ago

@pdmullen can you click approve? Actually need 2 approving reviews for a merge to go through.

BenWibking commented 1 month ago

@Yurlungur Do you know why the auto-merge isn't triggering?

pdmullen commented 1 month ago

Sometimes it just needs to be re-triggered... just attempted that