My "automatic" loop pattern fix in PR #1078 had an unexpected effect. Inner loop pattern tags, on some builds in riot, are now not being properly resolved on device. I think this is related to #321 and #319, though I'm not sure why constexpr isn't sufficient to make the tags get captured. The trivial solution, implemented here, is to just make the macro call the tag constructor manually. This only needs to be done for InnerLoopPatternTVR.
PR Checklist
[x] Code passes cpplint
[ ] New features are documented.
[ ] Adds a test for any bugs fixed. Adds tests for new features.
[x] Code is formatted
[ ] Changes are summarized in CHANGELOG.md
[ ] Change is breaking (API, behavior, ...)
[ ] Change is additionally added to CHANGELOG.md in the breaking section
[ ] PR is marked as breaking
[ ] Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
[ ] CI has been triggered on Darwin for performance regression tests.
[x] Docs build
[x] (@lanl.gov employees) Update copyright on changed files
PR Summary
My "automatic" loop pattern fix in PR #1078 had an unexpected effect. Inner loop pattern tags, on some builds in riot, are now not being properly resolved on device. I think this is related to #321 and #319, though I'm not sure why
constexprisn't sufficient to make the tags get captured. The trivial solution, implemented here, is to just make the macro call the tag constructor manually. This only needs to be done forInnerLoopPatternTVR.PR Checklist