Closed pdmullen closed 1 week ago
👍 Two things:
- Can you make sure that the isntrucitons for checking correctness in
benchmark/burgers
still work?- Make sure this only goes in after Add WithFluxes to IsRefined check #1127
Just went through the benchmark/burgers
test. It looks like it was shipping its own custom nbtotal
reduction. I eliminated this since this data is now outputted to hst
by default. The new history files are compatible with the burgers_diff.py
script, however, I'd note that this script had a bug in it such that no diffs would ever actually be reported --- fixed now.
👍 Two things:
- Can you make sure that the isntrucitons for checking correctness in
benchmark/burgers
still work?- Make sure this only goes in after Add WithFluxes to IsRefined check #1127
Just went through the
benchmark/burgers
test. It looks like it was shipping its own customnbtotal
reduction. I eliminated this since this data is now outputted tohst
by default. The new history files are compatible with theburgers_diff.py
script, however, I'd note that this script had a bug in it such that no diffs would ever actually be reported --- fixed now.
Thanks @pdmullen !
PR Summary
This PR adds the cycle and total number of MeshBlocks to the history file output. If we choose to merge this one, please merge it after #1127.
PR Checklist