parthmehta209 / PopularPhotos

Android app to view popular instagram photos
Apache License 2.0
0 stars 0 forks source link

Android Bootcamp project 1 #1

Open parthmehta209 opened 8 years ago

parthmehta209 commented 8 years ago

hi my app is ready for review. /cc @codepathreview @codepath.

Here are my questions:

  1. I have set the imageView width in the InstagramPhotoAdapter before loading the image from Picasso. Is that correct? I have tried 3 approaches and this one seemed smoother. I have read on stack overflow that messing with the imageView directly is not recommended if we use Picasso.
  2. What further optimization can be done to reduce image loading time. I have seen my app has more lag than the official Instagram app. Is there some kind of cache to be maintained or preloading the images before they are visible ?
codepathreview commented 8 years ago

:+1: Good work getting all required stories done. A few notes after checking out the code:

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.