search

parthosa / arcd-transcripts

Web app used by over 5000 alumni and graduating students of BITS Pilani to issue duplicate grade sheets and transcripts. It had an admin interface to filter requests and send emails to notify.
http://arcd.bits-pilani.ac.in/transcriptportal/transcripts/
1 stars 0 forks source link

Dont show empty fields from Admin dashboard. #4

Closed kudhru closed 7 years ago

kudhru commented 7 years ago

If Organization details or Mailing details or University details are empty, please don’t show their divisions/sections in the admin dashboard.

parthosa commented 7 years ago

Organization details ,Mailing details, University Details are still compulsory from backend.Please remove them. Also I am getting a 'TypeError at /api/transcripts/request-transcript/ 'RelatedManager' object is not iterable' error while submitting the form now

kudhru commented 7 years ago

So, the following request data works perfectly fine for me with Postman. 

{
    "phone_number" : "+918197801366",
    "number_of_transcripts" : "6",
    "sealed_required" : "False",
    "mailing_mode" : "4",
    "residential_address" : {
        "address_line_one": "Hello Address",
        "address_line_two": "Ramam Reti",
        "address_line_three": "Really Road",
        "landmark": "No landmark",
        "city": "Port Blair",
        "country": "India",
        "state": "Uttar Pradesh",
        "longitude": "25.22",
        "latitude": "36.43",
        "pincode": "282001"
    },
    "delivery_by_speed_post" : "True"
}

The success of the above request shows that mailing details, organization details and university details are not compulsory. Please send me the snapshot for the error which you are getting.

parthosa commented 7 years ago

I have made the required changes. However there seems to be an error from your end. I sent the following data:

{
  "phone_number": "999461307",
  "number_of_transcripts": "3",
  "sealed_required": "False",
  "residential_address": {
    "address_line_one": "asdfg",
    "address_line_two": "",
    "address_line_three": "",
    "landmark": "wesdfg",
    "city": "sdfg",
    "state": "esfgh",
    "country": "erfg",
    "pincode": "213432"
  },
  "organization_address": {
    "org_field": "True",
    "organization_name": "asdf",
    "address_line_one": "wertgf",
    "address_line_two": "",
    "address_line_three": "",
    "landmark": "eregf",
    "city": "sdfg",
    "state": "dfg",
    "country": "wfdg",
    "pincode": "32454"
  },
  "organization_name": "asdf",
  "delivery_by_speed_post": true
}

and this one as well

{
  "phone_number": "9999461307",
  "number_of_transcripts": "3",
  "sealed_required": "True",
  "residential_address": {
    "address_line_one": "BD 4104",
    "address_line_two": "BITS pilani",
    "address_line_three": "",
    "landmark": "rajasthan",
    "city": "Pilani",
    "state": "rajasthan",
    "country": "india",
    "pincode": "333031"
  },
  "delivery_by_speed_post": true,
  "university_details": [
    {
      "name": "stanford",
      "number_of_transcripts": "3",
      "address": {
        "address_line_one": "dum",
        "address_line_two": "du",
        "address_line_three": "",
        "landmark": "dum",
        "city": "dum",
        "state": "LA",
        "country": "USA",
        "pincode": "234352"
      }
    }
  ]
}

In both cases there is a 500 Internal Server Error

TypeError at /api/transcripts/request-transcript/
'RelatedManager' object is not iterable

Please see to this

kudhru commented 7 years ago

You are missing out the "mailing_mode" field in the JSON. Please add that and try again.

parthosa commented 7 years ago

Fixed this issue in 61bb80d