Update to Elm 0.18 - Githubissues

participateapp / web-client

Participate! is an app for democratic decision making

MIT License

6 stars 1 forks source link

Update to Elm 0.18 #51

Closed ThomasWeiser closed 7 years ago

ThomasWeiser commented 7 years ago

See Evan's upgrading guide.

Most changes will be mechanically ones. Http API changed, will have to adapt. Also have to wait for our dependencies to be updated.

oliverbarnes commented 7 years ago

Looks like navigation will have to adapt too:

elm-lang/navigation no longer has its own concept of a Parser. You just turn a Navigation.Location into a message and it is fed into your normal update function. This means Navigation.program is now much closer to Html.program so this should simplify things a bit.

ThomasWeiser commented 7 years ago

Update status of dependencies:

[x] debois/elm-mdl (8.0.0 Release notes)
[x] elm-community/result-extra
[x] elm-lang/core
[x] elm-lang/html
[x] elm-lang/navigation
[x] etaque/elm-simple-form (renamed to etaque/elm-form)
[x] evancz/elm-http (moved to elm-lang/http)
[x] evancz/url-parser
[x] noahzgordon/elm-jsonapi
[x] sporto/erl
[x] sporto/hop (may be dropped according to sporto)

ThomasWeiser commented 7 years ago

With the release of elm-mdl 8.x we are ready to update to Elm 0.18.

Will wait for #56 being merged.

oliverbarnes commented 7 years ago

Removing from the 0.0.1 milestone. Thought it's low hanging fruit, let's do it right after we're done with 0.0.1

ThomasWeiser commented 7 years ago

Should be working now. @oliverbarnes please review.

Some notes about the migration:

Source is a little bit smaller (-21 lines) and a quite bit clearer now.
Reimplemented most of routing (bigger changes in elm-lang/navigation; no more need for sporto/hop). IMHO code got easier to understand.
Also some bigger changes as a result of new elm-lang/http. Pulled in lukewestby/elm-http-builder and could drop some own helper functions.
Good Elm experience again: The compiler with its type checking guides reliably and helpfully thru refactorizations like this one. It provides great confidence in the correctness of the changed code.