search

participedia / frontend

DEPRECATED - see https://github.com/participedia/api/ instead
MIT License
3 stars 2 forks source link

Finicky New Window External Link Icon #869

Closed scottofletcher closed 5 years ago

scottofletcher commented 6 years ago

Clicking the little square with an arrow image is very finicky - half the time it just gets selected (four squares appear in each corner like when you're resizing an image in a Word Doc)

dethe commented 6 years ago

Where are you seeing that? It doesn't look like a Participedia icon, is your browser sending it? Can you capture a screen grab of it?

scottofletcher commented 6 years ago

Oh sorry, I wasn't sure if I could screen grab it so I just copied and pasted that little icon from Google Images (turned out way larger than I wanted it to). Here's a screenshot (note that my mouse is over the link but doesn't show up in the pic):

screenshot 2018-07-07 14 47 26
scottofletcher commented 6 years ago

Oh, and here's what often happens when I click on it

screenshot 2018-07-07 14 50 27

Sometimes it works (opens the link in a new tab), but mostly it does that annoying selecting thing.

dethe commented 6 years ago

OOOOOH, I see it now. It's only visible when editing an article.

So:

  1. I will be replacing the editing widget to support footnotes, and hopefully address many (or all?) other issues we're having with the current rich text edit widget.
  2. Clicking on a link in edit mode should never open up the link, it should always bring up a select menu because you are editing, not browsing.
  3. Websites opening up links in new tabs is not usually a good idea because it hijacks the users' agency. If the user wants to open the link in a new tab, they have tools: right-click, choose open in new tab, or ctrl-click (windows)/command-click (mac). Better to let the user decide when to open in a new tab.
  4. On the other hand, giving the user a visual clue or distinction between links which are external and links which are part of participedia can be a good idea, especially given how long it takes the map to load. That is a design matter and probably deserves its own issue.
jesicarson commented 6 years ago

Re: no 4, how could distinguishing between internal / external hyperlinks work? Icons? Not sure if that’s needed, but I’m open to it. And is the map problematic? Should that be addressed?

scottofletcher commented 6 years ago

1 - fantastic!! looking forward to it :) 2 - I actually like the ability to open links while editing the text because that's one of my editing jobs: checking for dead links. It would save me having to edit the entry, go to the reader view, check the urls, go back to the edit form, delete or replace those that are dead 3 - yep 4 - interesting idea - I'll defer to Jesi on how to design that

ascott commented 5 years ago

fixed with https://github.com/participedia/api/pull/354