search

particle-iot / particle-android

Particle Open Source for Android
Apache License 2.0
37 stars 38 forks source link

Move Tinker UI/update inspector views #72

Closed jensck closed 5 years ago

jensck commented 5 years ago

This is another good candidate for a video call walkthrough-style review. LOTS of lines changed here, but a lot of that is due to moving files to Kotlin and some renaming.

@RaimundasSakalauskas ping me on Slack when you're free to do the call for this review.

@monkbroc should I try to include you on the call with Raimis & I, find another time for just you & I, or do you want to just try to wade through this one the traditional way?

monkbroc commented 5 years ago

@monkbroc should I try to include you on the call with Raimis & I, find another time for just you & I, or do you want to just try to wade through this one the traditional way?

Invite me when you and Raimis look at this and if I'm available I'll participate. If not I'll wade through :)

jensck commented 5 years ago

Reviewed this live via Hangouts with @RaimundasSakalauskas . Merging.