search

particle-iot / particle-api-js

JS Library for the Particle API
Apache License 2.0
123 stars 53 forks source link

uploadProductFirmware only tests with Buffer, and doesn't test with filename #114

Open dmiddlecamp opened 4 years ago

dmiddlecamp commented 4 years ago

in the documentation: 

options.file Object Path or Buffer of the new firmware file
                             Either a path or Buffer of the file contents in Node, or a File or Blob in the browser.

test parameter appears to only set file to a buffer, and not a path file: new Buffer('ELF...'),

discovered because upload with path appears to not work as expected during testing / development.

dmiddlecamp commented 4 years ago

(stream of consciousness, still investigating)

it looks like maybe this isn't working in the browser (maybe just chrome / firefox), seems like it really expects a blob and not a path...

https://github.com/particle-iot/particle-api-js/blob/master/src/Agent.js#L139-L153

Am I correct in thinking this functionality just wasn't tested?