particle-iot / particle-cli-wrapper

Auto-updating wrapper for the Particle CLI
https://www.particle.io/cli
Apache License 2.0
0 stars 3 forks source link

feature/install-for-zsh #11

Closed busticated closed 4 years ago

busticated commented 4 years ago

https://app.clubhouse.io/particle/story/41485/update-cli-installer-script-to-support-zsh-and-other-shells

quickly glancing at the docs, it seem fish support is going to be a bit more fiddly 🤷‍♂

wraithan commented 4 years ago

https://unix.stackexchange.com/questions/71253/what-should-shouldnt-go-in-zshenv-zshrc-zlogin-zprofile-zlogout

It looks like there are also things like .zshenv where folks tend to put stuff like this, which is invoked for non-interactive shells too, so if someone makes some script.zsh the particle command will be there.

This would work for most people's cases though, where they're interactively calling particle.

Oh another gotcha with this I can see is now it's not available in bash, maybe we do this short term then long term (maybe when we add fish support) we install to any of the shell profiles we find, but only create if missing for the currently active shell?

busticated commented 4 years ago

agree on all fronts. updated the CH story w/ these details & tasks 👍