Can we have binary inspect also report PRODUCT_ID and PRODUCT_VERSION?

particle-iot / particle-cli

Command Line Interface for Particle Cloud and devices

Apache License 2.0

212 stars 92 forks source link

Can we have binary inspect also report PRODUCT_ID and PRODUCT_VERSION? #472

Open ScruffR opened 5 years ago

ScruffR commented 5 years ago

Currently particle binary inspect only reports this

firmware.bin
 CRC is ok (c0986d5e)
 Compiled for argon
 This is an application module number 1 at version 5
 It depends on a system module number 1 at version 326

But the embedded PRODUCT_ID and PRODUCT_VERSION are not provided.

beriberikix commented 5 years ago

I believe this is coming from particle-iot/binary-version-reader.

monkbroc commented 5 years ago

You are both correct. That should be possible since binary-version-reader can read this information.