particle-iot / particle-cli

Command Line Interface for Particle Cloud and devices
Apache License 2.0
212 stars 92 forks source link

Feature/sc 124023/delete refactor #709

Closed hugomontero closed 10 months ago

hugomontero commented 10 months ago

Description

This PR will change delete command in order to use LogicFunction Class

How to Test

  1. Pull down the branch: git pull && git checkout feature/sc-124023/delete-refactor
  2. Install dependencies: npm i
  3. Run tests: npm run test:ci && npm run test:e2e -- --grep "Logic Function Commands"
  4. Attempt to delete a logic function:
    • Delete by name: `npm start -- lf delete --name ""
    • Delete by id: `npm start -- lf delete --id ""
    • Delete wrong name/id: npm start -- lf delete --name "<wrong name>"
    • Delete without name/id: npm start -- lf delete

outcome

Related Issues / Discussions

Completeness

keeramis commented 10 months ago

@hugomontero do you want to fix the empty braces? I am guessing you should put the ID of the newly deployed logic function there. Currently it shows empty

image

hugomontero commented 10 months ago

@hugomontero do you want to fix the empty braces? I am guessing you should put the ID of the newly deployed logic function there. Currently it shows empty

image

I'll fix this one in the PR #710, since that one updates the way we show the texts (adding the spinners) 😄