Closed keeramis closed 10 months ago
@monkbroc Thanks for the clean up and the changes. I have one question for you.
Over here - https://github.com/particle-iot/particle-cli/blob/feature/ep-124394/remove-ymodem-flashing/src/cmd/flash.js#L53
We are still calling this function flashYModem
which gives the wrong idea because we removed ymodem flashing completely, and under-the-hood, it calls flashDevice
now. Why can't we make it call flashDevice
directly?
Description
ymodem
flashing is replaced using CLI local flashing over USB (which uses DFU and Control requests)How to Test
I will provide some examples here but kindly think of any creative ways that users would use
particle serial flash
orparticle flash --serial
command!npm start -- serial flash /path/to/file.bin
with single devicenpm start -- serial flash /path/to/file.bin
with multiple devicesnpm start -- serial flash /path/to/file.bin --port /port/num/of/device
npm start -- flash --serial /path/to/file.bin
with single devicenpm start -- flash --serial /path/to/file.bin
with multiple devicesnpm start -- flash --serial /path/to/file.bin --port /port/num/of/device
Related Issues / Discussions
https://app.shortcut.com/particle/epic/124394 https://app.shortcut.com/particle/story/124692/remove-ymodem-from-cli
Completeness