particle-iot / particle-cli

Command Line Interface for Particle Cloud and devices
Apache License 2.0
212 stars 92 forks source link

Feature/sc 125049/update join wifi to use control request when #714

Closed hugomontero closed 7 months ago

hugomontero commented 7 months ago

Description

This PR will change wifi connection to be over control request in case the device is not gen2

How to Test

  1. Pull down the branch: git pull && git checkout feature/sc-125049/update-join-wifi-to-use-control-request-when
  2. Install dependencies: npm i or npm ci (in to reinstall)
  3. Run tests: npm run test:ci
  4. Connect several devices and attempt to configure your wifi:
    • [ ] Gen 3 device (argon)
    • [ ] Gen 2 device (photon)
      • [ ] Next Gen devices (p2 / msom?)
      • [ ] Cellular device (boron or electron)

Outcome

Related Issues / Discussions

Story details: https://app.shortcut.com/particle/story/125049/update-join-wifi-to-use-control-request-when-is-possible

Completeness

technobly commented 6 months ago

@keeramis just a heads up that this PR appears to have removed the ability to setup Wi-Fi with JSON. Are we planning on adding that back?