search

particle-iot / particle-usb

A library for accessing Particle USB devices
Apache License 2.0
5 stars 1 forks source link

feature/ch42725/usb-dfu-confirm #20

Closed busticated closed 4 years ago

busticated commented 4 years ago

Currently, the .enterDfuMode() method returns before the targeted device is known to be in DFU mode. This makes it hard to compose with other dependent operations like flashing - see https://github.com/particle-iot/particle-cli/pull/555

busticated commented 4 years ago

@sergeuz how much does it matter that the openDeviceById() (src) that we're calling here is different than the one exposed to the consumer (src)?

sergeuz commented 4 years ago

@sergeuz how much does it matter that the openDeviceById() (src) that we're calling here is different than the one exposed to the consumer (src)?

I'd say it doesn't matter as we never expose the reopened instance to the calling code of enterDfuMode().