Do not ignore default-initialized message fields

particle-iot / particle-usb

A library for accessing Particle USB devices

Apache License 2.0

5 stars 1 forks source link

Do not ignore default-initialized message fields #25

Closed sergeuz closed 4 years ago

sergeuz commented 4 years ago

This PR fixes an issue where Device.sendRequest() doesn't return message fields which are not own properties of the decoded response message object. This is typically the case when some fields of a response message are set to zero.

sergeuz commented 4 years ago

Yeah, apart from a few integration tests, this repo doesn't have a single test for protobuf encoding/decoding.