Closed monkbroc closed 2 years ago
Thanks for the reviews. I'm not going to be able to prioritize this for a couple days, but at least it shows we're directionally aligned on how to add device-constants support to particle-usb.
Thanks for addressing the comments, @busticated. I added a mixin for Gen 3 devices as discussed with Julien. I'm going to merge this PR and test the library with the recent node-usb.
Story details: https://app.shortcut.com/particle/story/89893
Pull in all the platform information needed to generate particle-usb classes from the device-constants package to make adding new platforms easier.
Additional changes:
type
is now the same as the platformname
to avoid having yet another identifier for the platform (Asset-Tracker becomes tracker)Photon
,Electron
, etc from the package public interface because I couldn't find any use of those. OnlygetDevices
andopenDeviceById
are the only package public interfaces uses that I can find in our code.Open questions:
usb-requests
? Or can we rely on the fact that if there are USB ids, we'll be supporting vendor request?isPhoton
,isElectron
, etc methods on the device class? I cannot find any hints that these are used.TODO
getDevices
andopenDeviceById