particle-iot / spark-server

UNMAINTAINED - An API compatible open source server for interacting with devices speaking the spark-protocol
https://www.particle.io/
GNU Affero General Public License v3.0
441 stars 136 forks source link

Access tokens expiring caught me completely off guard #33

Open streblo opened 9 years ago

streblo commented 9 years ago

Please let me know if I should move this issue to a better spot.

My access token expired and I had no idea that this happens. I understand it is probably for good reason (security, etc.), but I think the user should be better informed by any of the following ways: 1) Notice of expiration date when creating access tokens ("This token will expire on xxxx-xx-xx.") 2) Email reminding 1 week before token expiration 3) Change the error message from "Authorization is required to perform that action." to "Expired access token."

Thank you for truly amazing platform -- can't wait to see where this goes!

zsup commented 9 years ago

good feedback! this is an issue that's come up before, but I'll leave this open so we remember. agreed that we should notify people about expiring tokens, and these are great suggestions.

streblo commented 9 years ago

/me dons his red face.

In my case, it was actually not Spark that lost authorization but rather the data logging platform (Google Sheets) which lost authorization. Today was a wonderfully serendipitous day if my error helped register a legit issue for Spark.