search

particle-iot / spark-setup-android

Former home of the Particle Device Setup library for Android
Apache License 2.0
23 stars 30 forks source link

squid:S2974 - Classes without "public" constructors should be "final" #17

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S2974 - Classes without "public" constructors should be "final"

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S2974

Please let me know if you have any questions.

M-Ezzat

jensck commented 8 years ago

Thanks for your contribution!

This is normally the kind of change that I'd be very happy to accept (i.e.: correctness/best practice fixes), but in this case I'm going to decline the PR.

Final classes and final methods only really need to be marked as such when it is imperative that behavior does not change in a subclass. That's not really the case here, and I don't want to make the code less flexible for consumers of the API when it doesn't really buy us anything.

If you have other changes along these lines though, please submit them!