search

particle-iot / spark-setup-android

Former home of the Particle Device Setup library for Android
Apache License 2.0
23 stars 30 forks source link

squid:S1213 - The members of an interface declaration or class should… #18

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S3052

Please let me know if you have any questions.

M-Ezzat

m-ezzat commented 8 years ago

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

jensck commented 8 years ago

Hi @m-ezzat , sorry for ignoring this!

I'm going to decline this PR. It's just shifting around the ordering of where some things are declared. I'm not fundamentally opposed to this, but especially since this SDK is an open source lib, I tried to optimize the files for readability by the community, e.g.: when someone is reading a class to look into its public interface, I want to show them the public entry points first before things like private constructors. That amounts to noise for someone who's just trying to skim the code.