particle-iot / spark-setup-ios

(DEPRECATED) Spark device setup library - Soft AP Cocoapod/Carthage lib for iOS
Apache License 2.0
19 stars 25 forks source link

Carthage/Build added to gitignore #45

Closed crenwick closed 8 years ago

crenwick commented 8 years ago

When this framework is added via carthage with the --use-submodules flag, it builds it in the ./Carthage/Checkouts/spark-setup-ios/Carthage/Build directory, marking this submodule as dirty.

Adding Carthage/Build to the gitignore list fixes this :)

idokleinman commented 8 years ago

Well, it's a matter of personal taste I think: https://github.com/Carthage/Carthage#using-submodules-for-dependencies

crenwick commented 8 years ago

It has no effect an app's ./Charthage/Build directory, only the ./Carthage/Checkouts/spark-setup-ios/Carthage/Build. So users can still use Carthage to their own preference. If anything, this adds more flexibility.

Spark-SDK-ios is already setup with this.

idokleinman commented 8 years ago

Okay!