search

particle4dev / komodo-rpc-lib

Komodo RPC Library for modern JavaScript
MIT License
4 stars 3 forks source link

switch to use http request instead of using komodo cli #12

Open particle4dev opened 5 years ago

particle4dev commented 5 years ago

Title: [Persona name] should (not) be able to [overarching action]

Business/User Value: Make source code testable

Acceptance Criteria GIVEN [necessary context and preconditions for story] WHEN [action] THEN [reaction]

DEV NOTES None

DESIGN Notes None

---other items that you may add to a story---

NEEDS PM None

NEEDS DESIGN None

Related issues None

/label ~"story"

pbca26 commented 5 years ago

better to give an option what to use in certain cases cli might be the only way to execute a command

particle4dev commented 5 years ago

@pbca26 I want to switch to use HTTP request because I want to make code testable Tried to build a mock server and call it via komodo cli but it always fails Then I took a look at bitcoin core lib (https://github.com/ruimarinho/bitcoin-core) they use HTTP request too (RPC call) But yes, we can keep both