Closed pbca26 closed 5 years ago
@pbca26 Hi In this articles, it said spawn is fit for the long-running application. I think it makes sense so I switch to use spawn by default. Is there any case do you want to use execFile for running komodod?
i think it's a good idea don't forget to add detached option for debug purposes
@pbca26 Hi just added detached option. Please double-check and let me know if it's good enough for your case.
source: https://github.com/particle4dev/komodo-rpc-lib/blob/master/src/daemon/control.js#L64 https://github.com/particle4dev/komodo-rpc-lib/blob/master/src/daemon/control.js#L73
Title: [Persona name] should (not) be able to [overarching action]
Business/User Value: As [persona] I want to [action by user] so that [value or need met]
Acceptance Criteria GIVEN [necessary context and preconditions for story] WHEN [action] THEN [reaction]
DEV NOTES can you also add spawn? via function arg or something https://github.com/KomodoPlatform/Agama/blob/master/routes/api/daemonControl.js#L238 it's good for debugging/dev when you need to restart an app multiple times running native
DESIGN Notes None
---other items that you may add to a story---
NEEDS PM None
NEEDS DESIGN None
Related issues https://github.com/particle4dev/komodo-rpc-lib/issues/13 https://github.com/particle4dev/komodo-rpc-lib/issues/22
/label ~"story"