Closed RCHowell closed 6 months ago
Base (6da7496d775fa2167228c3a97bfbbd725ddf8ba4) | c8fa109d5d8fa18b30e8b69c7daa86abb89522d9 | +/- | |
---|---|---|---|
% Passing | 92.54% | 92.54% | 0.00% |
:white_check_mark: Passing | 5384 | 5384 | 0 |
:x: Failing | 434 | 434 | 0 |
:large_orange_diamond: Ignored | 0 | 0 | 0 |
Total Tests | 5818 | 5818 | 0 |
Number passing in both: 5384
Number failing in both: 434
Number passing in Base (6da7496d775fa2167228c3a97bfbbd725ddf8ba4) but now fail: 0
Number failing in Base (6da7496d775fa2167228c3a97bfbbd725ddf8ba4) but now pass: 0
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.14%. Comparing base (
5bcde13
) to head (440ec01
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Relevant Issues
1400
TODO bench marking and versioning discussion. I'm porting these changes to Scribe now.
Description
This improves the pretty-printer performance (mem and stacksize) by using a linked-list rather than (similarly) creating a tree of links via link nodes. This is a more minimal implementation which uses fewer objects and stack frames. It also uses tail recursion when building the output string which mitigates stack size issues in that part.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO] Not yet.
Any backward-incompatible changes? [YES/NO] Yes. This is technically a breaking API change, but I don't think the pretty printer is a core API. To be discussed.
Any new external dependencies? [YES/NO] No
Do your changes comply with the Contributing Guidelines and Code Style Guidelines? [YES/NO] Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.