partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
536 stars 60 forks source link

qualified identifier #1411

Closed yliuuuu closed 3 months ago

yliuuuu commented 3 months ago

Relevant Issues

Description

Backward compatible:

I don't think this PR is backward incompatible as the new AST carries the notion of qualified identifier, and uses the identifier as the output for CREATE TABLE and DROP TABLE node.

The grammar rule changes affected the generated Antlr Parser but no user should directly invoke the Antlr generated parser anyway (i.e., The Antlr generated parser should not be sem-ver-ed in my opinion.)

The Pig AST remains unmodified.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 3 months ago

Conformance comparison report

Base (db1c85b0fcfccdf6e9c8069e45d48525cc81e947) 5aad39723b4c00bbe0e0b50eeaf9904905174711 +/-
% Passing 92.54% 92.54% 0.00%
:white_check_mark: Passing 5384 5384 0
:x: Failing 434 434 0
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (db1c85b0fcfccdf6e9c8069e45d48525cc81e947) but now fail: 0

Number failing in Base (db1c85b0fcfccdf6e9c8069e45d48525cc81e947) but now pass: 0

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.16%. Comparing base (db1c85b) to head (f1823eb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1411 +/- ## ============================================ + Coverage 73.14% 73.16% +0.01% Complexity 2393 2393 ============================================ Files 247 247 Lines 17623 17627 +4 Branches 3176 3178 +2 ============================================ + Hits 12890 12896 +6 + Misses 3856 3854 -2 Partials 877 877 ``` | [Flag](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1411/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | Coverage Δ | | |---|---|---| | [CLI](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `11.82% <ø> (ø)` | | | [EXAMPLES](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `80.07% <ø> (ø)` | | | [LANG](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `81.06% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.