Closed yliuuuu closed 3 months ago
Base (db1c85b0fcfccdf6e9c8069e45d48525cc81e947) | 5aad39723b4c00bbe0e0b50eeaf9904905174711 | +/- | |
---|---|---|---|
% Passing | 92.54% | 92.54% | 0.00% |
:white_check_mark: Passing | 5384 | 5384 | 0 |
:x: Failing | 434 | 434 | 0 |
:large_orange_diamond: Ignored | 0 | 0 | 0 |
Total Tests | 5818 | 5818 | 0 |
Number passing in both: 5384
Number failing in both: 434
Number passing in Base (db1c85b0fcfccdf6e9c8069e45d48525cc81e947) but now fail: 0
Number failing in Base (db1c85b0fcfccdf6e9c8069e45d48525cc81e947) but now pass: 0
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.16%. Comparing base (
db1c85b
) to head (f1823eb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Relevant Issues
Description
Backward compatible:
I don't think this PR is backward incompatible as the new AST carries the notion of qualified identifier, and uses the identifier as the output for CREATE TABLE and DROP TABLE node.
The grammar rule changes affected the generated Antlr Parser but no user should directly invoke the Antlr generated parser anyway (i.e., The Antlr generated parser should not be sem-ver-ed in my opinion.)
The Pig AST remains unmodified.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Any backward-incompatible changes? [YES/NO]
Any new external dependencies? [YES/NO]
Do your changes comply with the Contributing Guidelines and Code Style Guidelines? [YES/NO] Yes.
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.