Increases conformance by fixing small JOIN bug - Githubissues

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.

https://partiql.org/

Apache License 2.0

536 stars 60 forks source link

Increases conformance by fixing small JOIN bug #1417

Closed johnedquinn closed 2 months ago

johnedquinn commented 2 months ago

Relevant Issues

None

Description

Increases conformance by fixing small JOIN bug
Quantitative impact:
- "Number passing in legacy engine but fail in eval engine:" 760 --> 711
- Old evaluator stays the same for passing failing tests.
- Conformance gap decreased from 10.11% --> 9.26%

Other Information

Updated Unreleased Section in CHANGELOG: NO
Any backward-incompatible changes? NO
Any new external dependencies? NO
Do your changes comply with the Contributing Guidelines and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

johnedquinn commented 2 months ago

Closing as this has been resolved by: https://github.com/partiql/partiql-lang-kotlin/commit/00611ba39dcd2a23305226fe0a84eaeb47dde0a4