search

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
538 stars 60 forks source link

Merges main branch into v1 #1420

Closed RCHowell closed 5 months ago

RCHowell commented 5 months ago

Relevant Issues

N/A

Description

This PR merges the main branch into v1. We've made several changes to our typer and model. We will show some regression as operators such as COALESCE and NULLIF are not included in this PR.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

alancai98 commented 5 months ago

Not too sure why but some of the GitHub actions steps aren't running.

Also looks like there are a few conflicts w/ the v1 branch.

johnedquinn commented 5 months ago

Not too sure why but some of the GitHub actions steps aren't running.

Yeah, that is odd. I've been seeing that from my fork recently, and I'm not sure what it's from. It'd be nice to see the passing build and the change in conformance, if any.

alancai98 commented 5 months ago

Issue w/ the GH Actions gradle build/test step not running for v1 target branch should be fixed in https://github.com/partiql/partiql-lang-kotlin/pull/1423.

github-actions[bot] commented 5 months ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.51% 82.12% -10.38%
:white_check_mark: Passing 5382 4778 -604
:x: Failing 436 1040 604
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 4606

Number failing in both: 264

Number passing in legacy engine but fail in eval engine: 776

Number failing in legacy engine but pass in eval engine: 172 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 172 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (5f16e677ea6dac809b9544167f272e7d31f797de) 4ff50edcd508bc322412571e7ed3d03ee5a6c11a +/-
% Passing 92.52% 92.51% -0.02%
:white_check_mark: Passing 5383 5382 -1
:x: Failing 435 436 1
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5382

Number failing in both: 435

Number passing in Base (5f16e677ea6dac809b9544167f272e7d31f797de) but now fail: 1

Number failing in Base (5f16e677ea6dac809b9544167f272e7d31f797de) but now pass: 0 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang:. The following test(s) were previously passing but now fail:

Click here to see - MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (5f16e677ea6dac809b9544167f272e7d31f797de) 4ff50edcd508bc322412571e7ed3d03ee5a6c11a +/-
% Passing 82.43% 82.12% -0.31%
:white_check_mark: Passing 4796 4778 -18
:x: Failing 1022 1040 18
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 4764

Number failing in both: 1008

Number passing in Base (5f16e677ea6dac809b9544167f272e7d31f797de) but now fail: 32

Number failing in Base (5f16e677ea6dac809b9544167f272e7d31f797de) but now pass: 14 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 14 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.