search

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
536 stars 60 forks source link

Revert "PartiQL Eval - Planner Mode (#1385)" #1425

Closed RCHowell closed 2 months ago

RCHowell commented 2 months ago

Description

This reverts the planner mode as it made substantial changes to the planner which has already diverged from main. Let's get the merge from main in before adding these changes.

After merging https://github.com/partiql/partiql-lang-kotlin/pull/1420 — I will then re-apply the planner mode PR.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.51% 82.43% -10.07%
:white_check_mark: Passing 5382 4796 -586
:x: Failing 436 1022 586
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 4624

Number failing in both: 264

Number passing in legacy engine but fail in eval engine: 758

Number failing in legacy engine but pass in eval engine: 172 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 172 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (6103e9e27086a9b9ab01ef541f57da5071dda332) d421565983ecf10c484a03cd04bf434c8e576c7f +/-
% Passing 92.52% 92.51% -0.02%
:white_check_mark: Passing 5383 5382 -1
:x: Failing 435 436 1
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5382

Number failing in both: 435

Number passing in Base (6103e9e27086a9b9ab01ef541f57da5071dda332) but now fail: 1

Number failing in Base (6103e9e27086a9b9ab01ef541f57da5071dda332) but now pass: 0 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang:. The following test(s) were previously passing but now fail:

Click here to see - MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (6103e9e27086a9b9ab01ef541f57da5071dda332) d421565983ecf10c484a03cd04bf434c8e576c7f +/-
% Passing 82.85% 82.43% -0.42%
:white_check_mark: Passing 4821 4796 -25
:x: Failing 998 1022 24
:large_orange_diamond: Ignored 0 0 0
Total Tests 5819 5818 -1

Number passing in both: 4745

Number failing in both: 946

Number passing in Base (6103e9e27086a9b9ab01ef541f57da5071dda332) but now fail: 76

Number failing in Base (6103e9e27086a9b9ab01ef541f57da5071dda332) but now pass: 52 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 52 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.