partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
538 stars 60 forks source link

Apply "PartiQL Eval - Planner Mode (#1385)" #1429

Closed RCHowell closed 5 months ago

RCHowell commented 5 months ago

Description

Re-apply #1385

Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 5 months ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.52% 82.78% -9.75%
:white_check_mark: Passing 5383 4816 -567
:x: Failing 435 1002 567
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 4643

Number failing in both: 262

Number passing in legacy engine but fail in eval engine: 740

Number failing in legacy engine but pass in eval engine: 173 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 173 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (04e33a8c716eac240a33278bf87b0ba254411c67) b282bfe565a6e4ac6e3349c697e4317044a6f7d3 +/-
% Passing 92.51% 92.52% 0.02%
:white_check_mark: Passing 5382 5383 1
:x: Failing 436 435 -1
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5382

Number failing in both: 435

Number passing in Base (04e33a8c716eac240a33278bf87b0ba254411c67) but now fail: 0

Number failing in Base (04e33a8c716eac240a33278bf87b0ba254411c67) but now pass: 1 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (04e33a8c716eac240a33278bf87b0ba254411c67) b282bfe565a6e4ac6e3349c697e4317044a6f7d3 +/-
% Passing 82.12% 82.78% 0.65%
:white_check_mark: Passing 4778 4816 38
:x: Failing 1040 1002 -38
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 4739

Number failing in both: 963

Number passing in Base (04e33a8c716eac240a33278bf87b0ba254411c67) but now fail: 39

Number failing in Base (04e33a8c716eac240a33278bf87b0ba254411c67) but now pass: 77 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 77 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.