search

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
538 stars 60 forks source link

Handles null calls in dynamic dispatch #1436

Closed RCHowell closed 5 months ago

RCHowell commented 5 months ago

Description

Handles null calls in dynamic dispatch

Tests Addressed


    OVERLAY mismatched type, compileOption: LEGACY

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE null "}, compileOption: PERMISSIVE

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE null "}, compileOption: LEGACY

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE '[' "}, compileOption: PERMISSIVE

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE '[' "}, compileOption: LEGACY

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE 'S1' ESCAPE null "}, compileOption: PERMISSIVE

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE 'S1' ESCAPE null "}, compileOption: LEGACY

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null "}, compileOption: PERMISSIVE

    null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null "}, compileOption: LEGACY

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 5 months ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.52% 90.05% -2.48%
:white_check_mark: Passing 5383 5239 -144
:x: Failing 435 579 144
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5042

Number failing in both: 238

Number passing in legacy engine but fail in eval engine: 341

Number failing in legacy engine but pass in eval engine: 197 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 197 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) e52ae93f9d982adcc84bbc8beaa7c6a9c0810aa0 +/-
% Passing 92.51% 92.52% 0.02%
:white_check_mark: Passing 5382 5383 1
:x: Failing 436 435 -1
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5382

Number failing in both: 435

Number passing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now fail: 0

Number failing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now pass: 1 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) e52ae93f9d982adcc84bbc8beaa7c6a9c0810aa0 +/-
% Passing 89.91% 90.05% 0.14%
:white_check_mark: Passing 5231 5239 8
:x: Failing 587 579 -8
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5231

Number failing in both: 579

Number passing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now fail: 0

Number failing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now pass: 8 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE null "}, compileOption: PERMISSIVE - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE null "}, compileOption: LEGACY - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE '[' "}, compileOption: PERMISSIVE - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null ESCAPE '[' "}, compileOption: LEGACY - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE 'S1' ESCAPE null "}, compileOption: PERMISSIVE - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE 'S1' ESCAPE null "}, compileOption: LEGACY - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null "}, compileOption: PERMISSIVE - null value on any of the 3 inputs returns false{likeExpr:" d.sid LIKE null "}, compileOption: LEGACY