partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
538 stars 60 forks source link

Simplifies joins and fixes bugs #1438

Closed johnedquinn closed 2 months ago

johnedquinn commented 5 months ago

Relevant Issues

Description

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v1@5b86afc). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1 #1438 +/- ## ===================================== Coverage ? 13.70% Complexity ? 31 ===================================== Files ? 29 Lines ? 1729 Branches ? 190 ===================================== Hits ? 237 Misses ? 1470 Partials ? 22 ``` | [Flag](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1438/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | Coverage Δ | | |---|---|---| | [CLI](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1438/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `13.70% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RCHowell commented 5 months ago

Why draft?

johnedquinn commented 5 months ago

Why draft?

Currently incorporating the change for check() that is causing some of the conformance tests for joins to fail.