Closed johnedquinn closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
v1@5b86afc
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why draft?
Why draft?
Currently incorporating the change for check()
that is causing some of the conformance tests for joins to fail.
Relevant Issues
Description
iterator
inline function. This substantially simplifies our code at the cost of some performance. The reason I'm making this move is that there are bugs in the current implementation, and for the sake of our goal (conformance, not performance), I'm moving towards a simpler implementation. Once we pass all join tests, we can re-evaluate our implementation for performance reasons.Other Information
<struct evaluating to null>.a
returns null. Is this right? IMO, it makes the most sense, and it makes the modelling of JOINs very very easy.License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.