KOW - SPI modification - Githubissues

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.

https://partiql.org/

Apache License 2.0

536 stars 60 forks source link

KOW - SPI modification #1441

Open yliuuuu opened 2 months ago

yliuuuu commented 2 months ago

Relevant Issues

[Closes/Related To] Issue #XXX

Description

Add some documentation on public APIs/Interfaces in SPI package.
Refactor the connectorObject / ConnectorObjectHandle Class.
- The name object in SQL means a variety of things: Functions, Table, Views, Triggers, Assertions.
- We should avoid the name object to just refers to data object.
Add in IdentifyMapping interface to better encapsulate logics in BindingPath and ConnectorPath conversion.
- It might be possible that we need to encode special logic when convert a PartiQL Identifier when searching in the remote data source.
- Say using upper case vs lower case to search when the PartiQL Identifier is case insensitive.
- This interface should allow connector implementation to better encapsulate those logics.
Add in CreateTable function in ConnectorMetadata.
- The default behavior is to throw an PartiQLException.
- As we working on a connector that allows for write operation, we might change the function signature.

Other Information

Updated Unreleased Section in CHANGELOG: [YES/NO]
- < If NO, why? >
Any backward-incompatible changes? [YES/NO]
- < If YES, why? >
- < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in errors for users that are using our public APIs or the entities that have public visibility in our code-base. >
Any new external dependencies? [YES/NO]
- < If YES, which ones and why? >
- < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
Do your changes comply with the Contributing Guidelines and Code Style Guidelines? [YES/NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

Conformance comparison report-Cross Engine

	Base (legacy)	eval	+/-
% Passing	92.51%	89.91%	-2.60%
:white_check_mark: Passing	5382	5231	-151
:x: Failing	436	587	151
:large_orange_diamond: Ignored	0	0	0
Total Tests	5818	5818	0

Number passing in both: 5034

Number failing in both: 239

Number passing in legacy engine but fail in eval engine: 348

Number failing in legacy engine but pass in eval engine: 197 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 197 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

	Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13)	7eacef61ff9afa3a7675e1159beae01c543e22a7	+/-
% Passing	92.51%	92.51%	0.00%
:white_check_mark: Passing	5382	5382	0
:x: Failing	436	436	0
:large_orange_diamond: Ignored	0	0	0
Total Tests	5818	5818	0

Number passing in both: 5382

Number failing in both: 436

Number passing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now fail: 0

Number failing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

	Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13)	7eacef61ff9afa3a7675e1159beae01c543e22a7	+/-
% Passing	89.91%	89.91%	0.00%
:white_check_mark: Passing	5231	5231	0
:x: Failing	587	587	0
:large_orange_diamond: Ignored	0	0	0
Total Tests	5818	5818	0

Number passing in both: 5231

Number failing in both: 587

Number passing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now fail: 0

Number failing in Base (cc05d7ffbd8b9d55b819a458f4e9c820ceabaf13) but now pass: 0